Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input startHeight and headersList from a json file #15

Merged
merged 13 commits into from
Dec 27, 2024

Conversation

udit-gulati
Copy link
Contributor

@udit-gulati udit-gulati commented Dec 23, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

@udit-gulati udit-gulati requested a review from a team as a code owner December 23, 2024 10:52
@udit-gulati udit-gulati requested a review from vuvoth December 23, 2024 13:24
Copy link
Contributor

@vuvoth vuvoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved!
Please check my comments!

data/sample.json Show resolved Hide resolved
data/sample.json Show resolved Hide resolved
data_reader.go Outdated Show resolved Hide resolved
data_reader.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
data_reader.go Outdated Show resolved Hide resolved
data_reader.go Outdated Show resolved Hide resolved
data_reader.go Outdated Show resolved Hide resolved
data_reader.go Outdated Show resolved Hide resolved
udit-gulati and others added 11 commits December 27, 2024 11:46
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Udit Gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Udit Gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Udit Gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Udit Gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Udit Gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Udit Gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Udit Gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Udit Gulati <[email protected]>
@udit-gulati udit-gulati merged commit 1b98547 into master Dec 27, 2024
10 checks passed
@udit-gulati udit-gulati deleted the udit/data-file branch December 27, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants